HDDS-14919. Add a base class for all the SCM handler interfaces#10050
Open
Russole wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14919. Add a base class for all the SCM handler interfaces#10050Russole wants to merge 1 commit intoapache:masterfrom
Russole wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Hi @szetszwo, could you please help review this PR when you have time? Thanks! |
szetszwo
approved these changes
Apr 5, 2026
szetszwo
reviewed
Apr 5, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@Russole , on second thought, it is better to move up the getType() implementations; see the comments inlined. Found that when I was updating the code generator (HDDS-14973).
| this.ratisHandler = ratisHandler; | ||
| } | ||
|
|
||
| public abstract RequestType getType(); |
Contributor
There was a problem hiding this comment.
We should implement getType() here instead of adding it to all the subclasses:
public final RequestType getType() {
return getImpl().getType();
}| * manage deleted blocks and record them in the underlying persist store. | ||
| */ | ||
| public interface DeletedBlockLogStateManager { | ||
| public interface DeletedBlockLogStateManager extends SCMHandler { |
Contributor
There was a problem hiding this comment.
- Similarly, we should implement getType() here instead of the subclasses.
- We should do it for all the handler interfaces.
@Override
default RequestType getType() {
return RequestType.BLOCK;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCMHandlerinterface with agetType()method forSCMhandlersRequestTypefrom external parameters to handler implementationsgetProxyHandler(...)to deriveRequestTypefrom the handler instead of passing it explicitlyWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14919
How was this patch tested?